2026-03-13 23:39:51 -07:00
|
|
|
"""Tests for terminal/file tool availability in local dev environments."""
|
|
|
|
|
|
|
|
|
|
import importlib
|
|
|
|
|
|
|
|
|
|
from model_tools import get_tool_definitions
|
|
|
|
|
|
|
|
|
|
terminal_tool_module = importlib.import_module("tools.terminal_tool")
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class TestTerminalRequirements:
|
refactor: remove mini-swe-agent dependency — inline Docker/Modal backends (#2804)
Drop the mini-swe-agent git submodule. All terminal backends now use
hermes-agent's own environment implementations directly.
Docker backend:
- Inline the `docker run -d` container startup (was 15 lines in
minisweagent's DockerEnvironment). Our wrapper already handled
execute(), cleanup(), security hardening, volumes, and resource limits.
Modal backend:
- Import swe-rex's ModalDeployment directly instead of going through
minisweagent's 90-line passthrough wrapper.
- Bake the _AsyncWorker pattern (from environments/patches.py) directly
into ModalEnvironment for Atropos compatibility without monkey-patching.
Cleanup:
- Remove minisweagent_path.py (submodule path resolution helper)
- Remove submodule init/install from install.sh and setup-hermes.sh
- Remove mini-swe-agent from .gitmodules
- environments/patches.py is now a no-op (kept for backward compat)
- terminal_tool.py no longer does sys.path hacking for minisweagent
- mini_swe_runner.py guards imports (optional, for RL training only)
- Update all affected tests to mock the new direct subprocess calls
- Update README.md, CONTRIBUTING.md
No functionality change — all Docker, Modal, local, SSH, Singularity,
and Daytona backends behave identically. 6093 tests pass.
2026-03-24 07:30:25 -07:00
|
|
|
def test_local_backend_requirements(self, monkeypatch):
|
2026-03-13 23:39:51 -07:00
|
|
|
monkeypatch.setattr(
|
|
|
|
|
terminal_tool_module,
|
|
|
|
|
"_get_env_config",
|
|
|
|
|
lambda: {"env_type": "local"},
|
|
|
|
|
)
|
|
|
|
|
assert terminal_tool_module.check_terminal_requirements() is True
|
|
|
|
|
|
|
|
|
|
def test_terminal_and_file_tools_resolve_for_local_backend(self, monkeypatch):
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
terminal_tool_module,
|
|
|
|
|
"_get_env_config",
|
|
|
|
|
lambda: {"env_type": "local"},
|
|
|
|
|
)
|
|
|
|
|
tools = get_tool_definitions(enabled_toolsets=["terminal", "file"], quiet_mode=True)
|
|
|
|
|
names = {tool["function"]["name"] for tool in tools}
|
|
|
|
|
assert "terminal" in names
|
|
|
|
|
assert {"read_file", "write_file", "patch", "search_files"}.issubset(names)
|
2026-03-26 15:27:27 -07:00
|
|
|
|
|
|
|
|
def test_terminal_and_execute_code_tools_resolve_for_managed_modal(self, monkeypatch, tmp_path):
|
feat: ungate Tool Gateway — subscription-based access with per-tool opt-in
Replace the HERMES_ENABLE_NOUS_MANAGED_TOOLS env-var feature flag with
subscription-based detection. The Tool Gateway is now available to any
paid Nous subscriber without needing a hidden env var.
Core changes:
- managed_nous_tools_enabled() checks get_nous_auth_status() +
check_nous_free_tier() instead of an env var
- New use_gateway config flag per tool section (web, tts, browser,
image_gen) records explicit user opt-in and overrides direct API
keys at runtime
- New prefers_gateway(section) shared helper in tool_backend_helpers.py
used by all 4 tool runtimes (web, tts, image gen, browser)
UX flow:
- hermes model: after Nous login/model selection, shows a curses
prompt listing all gateway-eligible tools with current status.
User chooses to enable all, enable only unconfigured tools, or skip.
Defaults to Enable for new users, Skip when direct keys exist.
- hermes tools: provider selection now manages use_gateway flag —
selecting Nous Subscription sets it, selecting any other provider
clears it
- hermes status: renamed section to Nous Tool Gateway, added
free-tier upgrade nudge for logged-in free users
- curses_radiolist: new description parameter for multi-line context
that survives the screen clear
Runtime behavior:
- Each tool runtime (web_tools, tts_tool, image_generation_tool,
browser_use) checks prefers_gateway() before falling back to
direct env-var credentials
- get_nous_subscription_features() respects use_gateway flags,
suppressing direct credential detection when the user opted in
Removed:
- HERMES_ENABLE_NOUS_MANAGED_TOOLS env var and all references
- apply_nous_provider_defaults() silent TTS auto-set
- get_nous_subscription_explainer_lines() static text
- Override env var warnings (use_gateway handles this properly now)
2026-04-16 01:59:51 -04:00
|
|
|
monkeypatch.setattr("tools.tool_backend_helpers.managed_nous_tools_enabled", lambda: True)
|
|
|
|
|
monkeypatch.setattr(terminal_tool_module, "managed_nous_tools_enabled", lambda: True)
|
2026-03-26 15:27:27 -07:00
|
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
|
|
|
monkeypatch.setenv("USERPROFILE", str(tmp_path))
|
|
|
|
|
monkeypatch.delenv("MODAL_TOKEN_ID", raising=False)
|
|
|
|
|
monkeypatch.delenv("MODAL_TOKEN_SECRET", raising=False)
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
terminal_tool_module,
|
|
|
|
|
"_get_env_config",
|
|
|
|
|
lambda: {"env_type": "modal", "modal_mode": "managed"},
|
|
|
|
|
)
|
|
|
|
|
monkeypatch.setattr(
|
|
|
|
|
terminal_tool_module,
|
|
|
|
|
"is_managed_tool_gateway_ready",
|
|
|
|
|
lambda _vendor: True,
|
|
|
|
|
)
|
|
|
|
|
tools = get_tool_definitions(enabled_toolsets=["terminal", "code_execution"], quiet_mode=True)
|
|
|
|
|
names = {tool["function"]["name"] for tool in tools}
|
|
|
|
|
|
|
|
|
|
assert "terminal" in names
|
|
|
|
|
assert "execute_code" in names
|