From 87f5e1a25a21df7fcf1fbb5febeab63a2424701a Mon Sep 17 00:00:00 2001 From: Teknium <127238744+teknium1@users.noreply.github.com> Date: Thu, 30 Apr 2026 03:23:48 -0700 Subject: [PATCH] test(ssh): update tar pipe assertion for --no-overwrite-dir Existing test_tar_pipe_commands asserted the literal substring 'tar xf - -C /' in ssh_str, which is no longer present after the #17767 fix adds --no-overwrite-dir between 'tar xf -' and '-C /'. Split the one substring check into three independent assertions for the tar stdin mode, the new --no-overwrite-dir flag (regression guard for #17767), and the extract target. --- tests/tools/test_ssh_bulk_upload.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/tools/test_ssh_bulk_upload.py b/tests/tools/test_ssh_bulk_upload.py index 97cb39f53cb..cbdb6543495 100644 --- a/tests/tools/test_ssh_bulk_upload.py +++ b/tests/tools/test_ssh_bulk_upload.py @@ -166,10 +166,12 @@ class TestSSHBulkUpload: assert "-" in tar_cmd # stdout assert "-C" in tar_cmd - # ssh: extract from stdin at / + # ssh: extract from stdin at /, preserving existing dir modes (#17767) ssh_str = " ".join(ssh_cmd) assert "ssh" in ssh_str - assert "tar xf - -C /" in ssh_str + assert "tar xf -" in ssh_str + assert "--no-overwrite-dir" in ssh_str + assert "-C /" in ssh_str assert "testuser@example.com" in ssh_str def test_mkdir_failure_raises(self, mock_env, tmp_path):