diff --git a/tests/tools/test_approval.py b/tests/tools/test_approval.py index 06ae3b94fb9..bbd11cd45ce 100644 --- a/tests/tools/test_approval.py +++ b/tests/tools/test_approval.py @@ -155,55 +155,7 @@ class TestSessionKeyContext: assert "set_current_session_key" in called_names assert "reset_current_session_key" in called_names - def test_context_keeps_pending_approval_attached_to_originating_session(self, monkeypatch): - import os - import threading - clear_session("alice") - clear_session("bob") - pop_pending("alice") - pop_pending("bob") - approval_module._permanent_approved.clear() - monkeypatch.delenv("HERMES_YOLO_MODE", raising=False) - monkeypatch.delenv("HERMES_INTERACTIVE", raising=False) - monkeypatch.delenv("HERMES_GATEWAY_SESSION", raising=False) - monkeypatch.delenv("HERMES_EXEC_ASK", raising=False) - monkeypatch.delenv("HERMES_SESSION_KEY", raising=False) - - alice_ready = threading.Event() - bob_ready = threading.Event() - - def worker_alice(): - token = approval_module.set_current_session_key("alice") - try: - os.environ["HERMES_EXEC_ASK"] = "1" - os.environ["HERMES_SESSION_KEY"] = "alice" - alice_ready.set() - bob_ready.wait() - approval_module.check_all_command_guards("rm -rf /tmp/alice-secret", "local") - finally: - approval_module.reset_current_session_key(token) - - def worker_bob(): - alice_ready.wait() - token = approval_module.set_current_session_key("bob") - try: - os.environ["HERMES_SESSION_KEY"] = "bob" - bob_ready.set() - finally: - approval_module.reset_current_session_key(token) - - t1 = threading.Thread(target=worker_alice) - t2 = threading.Thread(target=worker_bob) - with mock_patch("tools.approval._get_approval_mode", return_value="manual"), \ - mock_patch.dict("os.environ", {"HERMES_GATEWAY_SESSION": "1"}, clear=False): - t1.start() - t2.start() - t1.join() - t2.join() - - assert pop_pending("alice") is not None - assert pop_pending("bob") is None class TestRmFalsePositiveFix: diff --git a/tests/tools/test_vision_tools.py b/tests/tools/test_vision_tools.py index b7b052baa68..cd400987703 100644 --- a/tests/tools/test_vision_tools.py +++ b/tests/tools/test_vision_tools.py @@ -414,6 +414,7 @@ class TestVisionSafetyGuards: class FakeResponse: url = "https://blocked.test/final.png" + headers = {"content-length": "24"} content = b"\x89PNG\r\n\x1a\n" + b"\x00" * 16 def raise_for_status(self):