Compare commits

...

2 Commits

Author SHA1 Message Date
Hermes Agent
de7253dcdf fix: use consistent fallback for pickle_key derivation
Address review: _pickle_key now uses _acct_id (which has the 'hermes'
fallback) instead of raw self._user_id, so both values stay consistent
when user_id is empty.
2026-04-11 17:26:17 +00:00
Hermes Agent
050f496816 fix(matrix): pass required args to MemoryCryptoStore for mautrix ≥0.21
MemoryCryptoStore.__init__() now requires account_id and pickle_key
positional arguments as of mautrix 0.21. The migration from matrix-nio
(commit 1850747) didn't account for this, causing E2EE initialization
to fail with:

  MemoryCryptoStore.__init__() missing 2 required positional arguments:
  'account_id' and 'pickle_key'

Pass self._user_id as account_id and derive pickle_key from the same
user_id:device_id pair already used for the on-disk HMAC signature.

Update the test stub to accept the new parameters.

Fixes #7803
2026-04-11 17:03:38 +00:00
2 changed files with 13 additions and 2 deletions

View File

@@ -352,7 +352,16 @@ class MatrixAdapter(BasePlatformAdapter):
from mautrix.crypto import OlmMachine from mautrix.crypto import OlmMachine
from mautrix.crypto.store import MemoryCryptoStore from mautrix.crypto.store import MemoryCryptoStore
crypto_store = MemoryCryptoStore() # account_id and pickle_key are required by mautrix ≥0.21.
# Use the Matrix user ID as account_id for stable identity.
# pickle_key secures in-memory serialisation; derive from
# the same user_id:device_id pair used for the on-disk HMAC.
_acct_id = self._user_id or "hermes"
_pickle_key = f"{_acct_id}:{self._device_id}"
crypto_store = MemoryCryptoStore(
account_id=_acct_id,
pickle_key=_pickle_key,
)
# Restore persisted crypto state from a previous run. # Restore persisted crypto state from a previous run.
# Uses HMAC to verify integrity before unpickling. # Uses HMAC to verify integrity before unpickling.

View File

@@ -157,7 +157,9 @@ def _make_fake_mautrix():
mautrix_crypto_store = types.ModuleType("mautrix.crypto.store") mautrix_crypto_store = types.ModuleType("mautrix.crypto.store")
class MemoryCryptoStore: class MemoryCryptoStore:
pass def __init__(self, account_id="", pickle_key=""):
self.account_id = account_id
self.pickle_key = pickle_key
mautrix_crypto_store.MemoryCryptoStore = MemoryCryptoStore mautrix_crypto_store.MemoryCryptoStore = MemoryCryptoStore