hermes-agent

mirror of https://github.com/NousResearch/hermes-agent.git synced 2026-05-06 02:37:05 +08:00

Files

briandevans 9fa3a093f2 fix(local): test root as ancestor candidate; use real pipe for fake stdout

Address Copilot review on PR #17569:

1. _resolve_safe_cwd never tested the filesystem root because the loop
   exited when `os.path.dirname(parent) == parent`, which is true once
   `parent == '/'`. Restructure so the root is checked before the
   self-equal exit. Adds `test_returns_root_when_only_root_exists` —
   regression-guarded by reverting the loop and watching it fail.

2. The fake `Popen.stdout` was a `MagicMock`; `BaseEnvironment._wait_for_process`
   calls `proc.stdout.fileno()` then `select.select`/`os.read` against it,
   which raised `TypeError: fileno() returned a non-integer` (visible as a
   thread exception in test output) and could in theory read from an
   unrelated real fd. Hand `fake_popen` a real `os.pipe()` with the write
   end pre-closed so the drain loop sees EOF immediately. Helper records
   each fd so the test cleans up after itself.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-04 15:31:47 -07:00

__init__.py

feat(environments): add Daytona cloud sandbox backend

2026-03-05 10:02:21 -08:00

base.py

fix(env): pass -- to cd for hyphen-prefixed workdirs

2026-05-04 04:45:03 -07:00

daytona.py

fix: harden sync_back — PID-suffix temp path, size cap, lifecycle guards

2026-04-16 19:39:21 -07:00

docker.py

feat(docker): run container as host user to avoid root-owned bind mounts