Teknium
b10e38e392
fix(skills): pin protects against deletion only, not edits ( #20220 )
...
Previously, pinning a skill blocked every skill_manage write action
(edit, patch, delete, write_file, remove_file). The 'hard fence'
design conflated two concerns:
1. Pin as deletion protection — don't let the curator archive
or the agent delete a stable skill.
2. Pin as content freeze — don't let the agent rewrite it mid-conversation.
In practice (1) is what users pin for: they want a skill to survive
curator passes. (2) created friction — agents finding a new pitfall
in a pinned skill had to ask the user to unpin, then the agent
patches, then the user re-pins. The dance discouraged skill
maintenance and pinned skills went stale.
This narrows the _pinned_guard to skill_manage(action='delete') only.
Patches, edits, and supporting-file writes go through on pinned
skills so the agent can keep improving them. The curator's own
pinned-skip behavior (agent/curator.py:271 for auto-archive,
line 349 for the LLM review prompt) is unchanged — curator still
never touches pinned skills.
Changes:
- tools/skill_manager_tool.py: remove _pinned_guard calls from
_edit_skill, _patch_skill, _write_file, _remove_file; keep on
_delete_skill. Updated _pinned_guard docstring and error message.
- tools/skill_manager_tool.py: updated skill_manage model-facing tool
description to reflect the new semantic.
- website/docs/user-guide/features/curator.md: updated pinning
section.
- tests/tools/test_skill_manager_tool.py: flipped refuses-pinned
tests for edit/patch/write_file/remove_file into allowed-when-pinned;
kept test_delete_refuses_pinned (strengthened assertion to check the
'cannot be deleted' wording).
Closes #18354
2026-05-05 05:43:10 -07:00
..
2026-04-29 20:05:32 -07:00
2026-03-23 07:43:12 -07:00
2026-04-29 23:18:55 -07:00
2026-04-27 20:08:33 -07:00
2026-04-27 06:42:32 -07:00
2026-05-04 04:45:03 -07:00
2026-04-16 04:07:11 -07:00
2026-04-20 23:20:33 -07:00
2026-04-24 03:46:46 -07:00
2026-04-17 16:05:04 -07:00
2026-04-24 03:46:46 -07:00
2026-04-28 07:03:44 -07:00
2026-04-08 13:44:58 -07:00
2026-04-16 04:19:34 -07:00
2026-04-20 00:32:09 -07:00
2026-03-28 17:25:04 -07:00
2026-04-10 13:05:44 -07:00
2026-05-04 03:12:30 -07:00
2026-04-26 09:57:58 -07:00
2026-04-29 23:18:55 -07:00
2026-04-01 12:03:56 -07:00
2026-04-26 18:27:13 -07:00
2026-04-30 20:33:33 -07:00
2026-04-23 22:23:37 -07:00
2026-04-11 02:58:48 -07:00
2026-04-26 19:05:52 -07:00
2026-04-29 23:18:55 -07:00
2026-04-18 01:46:25 -07:00
2026-04-30 03:31:16 -07:00
2026-04-29 07:22:33 -07:00
2026-03-27 04:03:00 -07:00
2026-04-10 03:44:43 -07:00
2026-04-26 08:32:09 -07:00
2026-04-25 22:07:12 -07:00
2026-04-29 06:35:34 -07:00
2026-04-08 17:23:15 -07:00
2026-04-24 04:58:32 -07:00
2026-03-26 14:50:26 -07:00
2026-05-04 05:22:35 -07:00
2026-04-30 20:37:12 -07:00
2026-04-29 16:16:43 +10:00
2026-04-14 21:20:37 -07:00
2026-04-29 21:56:51 -07:00
2026-04-21 06:14:25 -07:00
2026-04-17 19:04:11 -07:00
2026-05-05 04:54:17 -07:00
2026-05-04 12:37:09 -07:00
2026-04-17 19:26:40 -07:00
2026-04-27 00:17:26 -07:00
2026-04-23 15:11:52 -07:00
2026-04-21 16:41:26 -07:00
2026-04-30 06:36:50 -07:00
2026-04-10 03:01:46 -07:00
2026-04-10 21:14:32 -07:00
2026-04-20 00:58:16 -07:00
2026-04-08 17:23:15 -07:00
2026-05-03 08:52:41 -07:00
2026-04-13 05:15:05 -07:00
2026-03-14 11:27:02 -07:00
2026-04-21 02:03:46 -07:00
2026-04-29 07:22:33 -07:00
2026-05-04 05:08:51 -07:00
2026-04-13 04:45:07 -07:00
2026-04-21 02:04:21 -07:00
2026-04-23 03:01:18 -07:00
2026-04-21 13:35:31 -07:00
2026-04-28 22:16:08 -07:00
2026-04-14 02:18:38 -07:00
2026-05-04 05:04:01 -07:00
2026-03-27 15:28:19 -07:00
2026-04-19 11:27:50 -07:00
2026-04-29 07:22:33 -07:00
2026-05-04 15:31:47 -07:00
2026-04-29 23:18:55 -07:00
2026-04-23 05:15:37 -07:00
2026-04-09 16:24:53 -07:00
2026-04-16 12:36:49 -07:00
2026-04-16 12:36:49 -07:00
2026-04-15 13:29:05 -07:00
2026-04-09 13:17:06 -07:00
2026-04-16 12:36:49 -07:00
2026-04-21 05:19:03 -07:00
2026-04-29 20:05:32 -07:00
2026-04-19 16:31:07 -07:00
2026-04-19 16:31:07 -07:00
2026-04-16 21:57:10 -07:00
2026-04-16 21:57:10 -07:00
2026-05-04 04:42:18 -07:00
2026-04-04 10:18:57 -07:00
2026-04-16 21:57:10 -07:00
2026-04-26 18:21:20 -07:00
2026-04-29 20:05:32 -07:00
2026-04-16 21:57:10 -07:00
2026-04-04 10:18:57 -07:00
2026-05-03 15:23:33 -07:00
2026-04-28 04:58:03 -07:00
2026-04-14 10:18:05 -07:00
2026-04-13 16:32:04 -07:00
2026-04-23 15:14:11 -07:00
2026-04-12 06:18:05 +05:30
2026-04-29 07:22:33 -07:00
2026-04-10 03:01:46 -07:00
2026-04-12 00:36:22 -07:00
2026-04-05 12:46:07 -07:00
2026-04-22 14:45:50 -07:00
2026-04-10 16:47:44 -07:00
2026-04-29 04:59:21 -07:00
2026-04-13 16:32:04 -07:00
2026-04-30 19:43:03 -07:00
2026-04-23 15:11:52 -07:00
2026-05-05 04:25:18 -07:00
2026-03-17 02:02:57 -07:00
2026-04-15 17:37:43 -07:00
2026-04-30 04:28:08 -07:00
2026-05-04 05:07:40 -07:00
2026-04-26 11:55:02 -07:00
2026-04-20 13:24:15 -07:00
2026-03-16 19:01:39 +03:00
2026-04-10 03:44:43 -07:00
2026-04-01 04:19:19 -07:00
2026-05-05 05:43:10 -07:00
2026-05-04 02:42:16 -07:00
2026-04-01 04:19:19 -07:00
2026-05-05 04:55:22 -07:00
2026-04-23 06:20:47 -07:00
2026-03-14 23:15:04 -07:00
2026-05-04 01:28:12 -07:00
2026-04-23 05:09:08 -07:00
2026-04-29 07:22:33 -07:00
2026-04-29 21:56:47 -07:00
2026-04-24 07:06:11 -07:00
2026-04-30 04:32:28 -07:00
2026-04-20 03:07:32 -07:00
2026-04-16 19:39:21 -07:00
2026-04-19 16:53:11 -07:00
2026-04-29 16:16:43 +10:00
2026-04-04 16:57:24 -07:00
2026-04-19 16:47:20 -07:00
2026-04-08 21:37:51 -07:00
2026-04-20 23:20:33 -07:00
2026-04-29 07:22:33 -07:00
2026-03-29 21:51:44 -07:00
2026-04-09 16:24:53 -07:00
2026-04-29 07:22:33 -07:00
2026-04-30 20:38:09 -07:00
2026-04-08 17:23:15 -07:00
2026-04-29 23:18:55 -07:00
2026-04-11 16:22:50 -07:00
2026-04-26 19:02:55 -07:00
2026-04-07 17:19:07 -07:00
2026-04-23 21:51:19 -07:00
2026-05-04 03:14:59 -07:00
2026-04-29 23:18:55 -07:00
2026-05-04 04:41:36 -07:00
2026-04-29 23:18:55 -07:00
2026-04-30 02:53:20 -07:00
2026-04-29 23:18:55 -07:00
2026-04-16 14:23:16 -07:00
2026-04-21 01:28:32 -07:00
2026-04-21 17:49:39 -07:00
2026-04-30 02:53:20 -07:00
2026-04-30 02:53:20 -07:00
2026-05-04 12:36:09 -07:00
2026-04-26 18:27:13 -07:00
2026-04-29 07:22:33 -07:00
2026-05-04 00:04:36 +05:30
2026-04-20 00:32:09 -07:00
2026-05-04 01:36:07 -07:00
2026-04-09 16:24:53 -07:00
2026-04-25 06:41:58 -07:00
2026-04-28 02:09:30 -07:00
2026-04-09 13:17:06 -07:00
2026-03-30 08:10:14 -07:00
2026-04-24 03:46:46 -07:00
2026-04-30 20:37:37 -07:00
2026-04-24 03:46:46 -07:00