briandevans f54935738c fix(cron): surface agent run_conversation failure flags as job failure ...

run_job() ignored the result's `failed=True` / `completed=False` flags
that agent.run_conversation populates on API exhaustion, mid-run
interrupts, and model aborts. Because final_response on those paths is
often a non-empty error string ("API call failed after 3 retries:
Request timed out."), the existing empty-response soft-fail in
_process_job did not trip either: the error text was delivered as if it
were the agent's reply and last_status was set to "ok" with no error
notification. Detect those flags right after the dict-shape guard and
raise so the existing except handler builds the proper failure tuple,
preserving the agent's error message via result["error"].

Adds a parametrized regression covering: API-retry-exhausted with error
text in final_response, completed=False with no final_response,
completed=False without an explicit failed flag, and the partial-reply
plus failed=True case. Plus a guard that a normal completed=True success
result is still treated as success.

Fixes #17855

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-30 03:27:37 -07:00

..

__init__.py

docs: clarify gateway service scopes (#1378)

2026-03-14 21:17:41 -07:00

jobs.py

fix(install): promote croniter to a core dependency

2026-04-29 10:35:28 -07:00

scheduler.py

fix(cron): surface agent run_conversation failure flags as job failure

2026-04-30 03:27:37 -07:00