Teknium
b50bc13ef9
fix(config): preserve YAML lists in hermes config set ( #17876 )
...
_set_nested unconditionally replaced any non-dict value with an empty
dict when walking the dotted path, which silently destroyed list-typed
config nodes the moment someone set a value with a numeric index
(e.g. 'hermes config set custom_providers.0.api_key NEW'). Any sibling
entries and any fields inside the targeted entry that the user didn't
write were lost.
Fix:
- _set_nested now detects list nodes and navigates by numeric index,
and preserves both dicts AND lists at intermediate positions (scalars
are still replaced so bare-scalar -> nested overrides keep working).
- set_config_value drops its duplicated navigation logic and calls
_set_nested instead -- single source of truth for the rules.
Regression tests (tests/hermes_cli/test_set_config_value.py):
- test_indexed_set_preserves_sibling_list_entries -- exact #17876 repro
- test_indexed_set_preserves_non_targeted_fields -- inner-dict fields survive
- test_deeper_nesting_through_list -- dict -> list -> dict -> scalar path
35/35 existing + new tests pass.
E2E-verified with the issue's repro against a real on-disk config.yaml --
list stays a list, entry 0 updated, entry 1 intact.
Closes #17876
2026-04-30 04:32:17 -07:00
..
2026-02-26 03:20:08 +03:00
2026-04-20 22:21:21 -07:00
2026-04-24 07:14:00 -07:00
2026-04-07 17:19:07 -07:00
2026-04-07 17:19:07 -07:00
2026-04-29 21:56:51 -07:00
2026-04-26 05:43:31 -07:00
2026-04-28 03:45:52 -07:00
2026-04-20 20:53:51 -07:00
2026-04-21 14:31:48 -05:00
2026-04-07 17:19:07 -07:00
2026-04-07 17:19:07 -07:00
2026-04-24 04:53:32 -07:00
2026-04-29 23:18:55 -07:00
2026-04-24 05:20:05 -07:00
2026-04-14 01:43:45 -07:00
2026-04-08 13:46:30 -07:00
2026-04-24 03:00:33 -07:00
2026-04-20 00:47:39 -07:00
2026-04-25 18:48:43 -07:00
2026-04-28 01:50:23 -07:00
2026-04-07 17:59:42 -07:00
2026-03-18 03:17:37 -07:00
2026-04-23 23:28:34 -07:00
2026-04-28 03:53:11 -07:00
2026-04-09 16:24:53 -07:00
2026-04-29 23:18:55 -07:00
2026-04-11 01:52:58 -07:00
2026-04-28 15:11:47 -05:00
2026-03-09 21:36:29 -07:00
2026-04-19 12:39:58 -07:00
2026-04-24 04:53:32 -07:00
2026-04-26 11:38:32 -07:00
2026-04-14 10:45:42 -07:00
2026-04-21 14:23:45 -07:00
2026-04-29 23:18:55 -07:00
2026-04-17 19:03:26 -07:00
2026-04-28 01:40:25 -07:00
2026-04-28 22:22:45 -07:00
2026-04-29 23:18:55 -07:00
2026-04-10 03:44:43 -07:00
2026-04-28 01:18:09 -07:00
2026-04-24 05:09:08 -07:00
2026-04-24 03:33:29 -07:00
2026-04-24 05:09:08 -07:00
2026-04-19 05:19:22 -07:00
2026-04-25 18:47:53 -07:00
2026-04-26 21:52:12 -07:00
2026-04-30 02:30:20 -07:00
2026-04-22 15:27:54 -05:00
2026-04-16 06:48:33 -07:00
2026-04-20 22:14:29 -07:00
2026-04-20 22:14:29 -07:00
2026-04-17 05:08:07 -07:00
2026-04-14 23:13:11 -07:00
2026-04-29 21:56:51 -07:00
2026-04-22 05:51:44 -07:00
2026-04-13 04:35:37 -07:00
2026-04-26 06:19:04 -07:00
2026-04-09 16:24:53 -07:00
2026-03-14 12:11:23 -07:00
2026-04-29 23:18:55 -07:00
2026-04-10 21:15:47 -07:00
2026-04-30 03:29:57 -07:00
2026-04-24 04:46:17 -07:00
2026-04-20 23:20:33 -07:00
2026-04-27 11:17:59 -07:00
2026-04-20 20:53:51 -07:00
2026-04-29 20:33:29 -07:00
2026-04-23 01:56:09 -07:00
2026-03-29 21:54:36 -07:00
2026-04-11 17:23:36 -07:00
2026-03-30 17:34:43 -07:00
2026-04-16 21:57:10 -07:00
2026-04-29 21:56:47 -07:00
2026-03-17 03:48:44 -07:00
2026-04-16 06:48:33 -07:00
2026-04-26 05:46:43 -07:00
2026-04-24 05:24:54 -07:00
2026-04-17 06:33:21 -07:00
2026-04-28 12:27:36 -07:00
2026-04-25 18:47:53 -07:00
2026-04-16 01:16:14 -07:00
2026-04-30 04:32:11 -07:00
2026-04-24 04:58:46 -07:00
2026-04-08 19:58:16 -07:00
2026-04-29 21:56:51 -07:00
2026-04-22 17:33:42 -07:00
2026-04-25 14:13:02 -05:00
2026-04-20 22:14:03 -07:00
2026-04-13 04:33:52 -07:00
2026-04-26 19:02:55 -07:00
2026-04-24 04:58:46 -07:00
2026-04-16 07:17:45 -07:00
2026-04-22 17:33:42 -07:00
2026-04-21 05:19:43 -07:00
2026-04-24 05:20:05 -07:00
2026-03-16 06:07:45 -07:00
2026-03-14 10:35:14 -07:00
2026-04-17 01:05:09 -07:00
2026-04-21 21:30:10 -07:00
2026-04-17 01:05:09 -07:00
2026-04-24 07:06:11 -07:00
2026-04-01 11:20:33 -07:00
2026-04-29 14:21:35 -07:00
2026-04-28 01:28:25 -07:00
2026-04-29 23:18:55 -07:00
2026-04-09 14:20:16 -07:00
2026-04-27 21:24:08 -07:00
2026-04-28 01:47:20 -07:00
2026-04-29 20:33:29 -07:00
2026-04-27 08:52:12 -07:00
2026-04-29 09:53:42 -07:00
2026-04-26 18:49:48 -07:00
2026-04-26 18:31:07 -07:00
2026-04-30 04:32:17 -07:00
2026-04-19 00:28:25 -07:00
2026-04-09 16:24:53 -07:00
2026-04-29 21:56:51 -07:00
2026-04-10 21:15:59 -07:00
2026-04-10 03:44:43 -07:00
2026-04-25 22:02:02 -07:00
2026-04-26 18:49:48 -07:00
2026-04-29 21:56:51 -07:00
2026-04-16 20:43:41 -07:00
2026-04-25 22:02:02 -07:00
2026-04-29 23:18:55 -07:00
2026-04-24 03:46:46 -07:00
2026-04-26 20:57:10 -07:00
2026-03-17 01:59:07 -07:00
2026-03-28 14:32:23 -07:00
2026-03-11 00:50:39 -07:00
2026-04-28 18:47:14 -05:00
2026-04-24 05:30:05 -07:00
2026-04-28 12:27:36 -07:00
2026-04-29 07:22:33 -07:00
2026-04-17 01:05:09 -07:00
2026-03-30 11:17:15 -07:00
2026-04-25 18:25:13 -07:00
2026-04-28 03:45:52 -07:00
2026-04-10 02:57:39 -07:00
2026-04-20 00:52:50 -07:00
2026-04-13 16:32:04 -07:00
2026-03-29 20:05:59 -07:00
2026-04-28 01:23:16 -07:00
2026-03-26 13:39:41 -07:00
2026-04-27 16:43:48 -07:00
2026-04-29 16:55:27 -07:00
2026-04-29 20:05:32 -07:00
2026-04-19 19:38:02 -07:00
2026-04-19 22:43:09 -07:00
2026-04-23 14:01:57 -07:00
2026-04-17 21:29:24 -07:00
2026-04-30 02:46:56 -07:00
2026-04-30 03:29:48 -07:00
2026-04-23 16:18:15 -07:00
2026-04-21 06:26:35 -07:00
2026-04-30 01:34:08 -07:00
2026-04-26 18:43:57 -07:00
2026-03-28 14:33:35 -07:00
2026-04-28 03:45:52 -07:00