mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-28 15:01:34 +08:00
Closes #15775. Title generation swallowed exceptions at debug level and returned None, so a depleted auxiliary provider (e.g. OpenRouter 402) silently left sessions with NULL titles. Reporter observed 45 untitled sessions accumulated over 19 days with no user-visible indication. - agent/title_generator.py: accept optional failure_callback, bump log to WARNING, invoke callback on call_llm exception (swallowing callback errors so nothing can crash the fire-and-forget worker thread). - cli.py, gateway/run.py: pass agent._emit_auxiliary_failure as the callback so failures route through the existing user-visible warning channel. - tests: cover callback fires / errors are swallowed / no-callback legacy behavior / maybe_auto_title forwards kwarg to worker.
155 lines
5.3 KiB
Python
155 lines
5.3 KiB
Python
"""Auto-generate short session titles from the first user/assistant exchange.
|
|
|
|
Runs asynchronously after the first response is delivered so it never
|
|
adds latency to the user-facing reply.
|
|
"""
|
|
|
|
import logging
|
|
import threading
|
|
from typing import Callable, Optional
|
|
|
|
from agent.auxiliary_client import call_llm
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
# Callback signature: (task_name, exception) -> None. Used to surface
|
|
# auxiliary failures to the user through AIAgent._emit_auxiliary_failure
|
|
# so silent-drops (e.g. OpenRouter 402 exhausting the fallback chain)
|
|
# become visible instead of piling up as NULL session titles.
|
|
FailureCallback = Callable[[str, BaseException], None]
|
|
|
|
_TITLE_PROMPT = (
|
|
"Generate a short, descriptive title (3-7 words) for a conversation that starts with the "
|
|
"following exchange. The title should capture the main topic or intent. "
|
|
"Return ONLY the title text, nothing else. No quotes, no punctuation at the end, no prefixes."
|
|
)
|
|
|
|
|
|
def generate_title(
|
|
user_message: str,
|
|
assistant_response: str,
|
|
timeout: float = 30.0,
|
|
failure_callback: Optional[FailureCallback] = None,
|
|
) -> Optional[str]:
|
|
"""Generate a session title from the first exchange.
|
|
|
|
Uses the auxiliary LLM client (cheapest/fastest available model).
|
|
Returns the title string or None on failure.
|
|
|
|
``failure_callback`` is invoked with ``(task, exception)`` when the
|
|
auxiliary call raises — the caller typically wires this to
|
|
``AIAgent._emit_auxiliary_failure`` so the user sees a warning instead
|
|
of silently accumulating untitled sessions.
|
|
"""
|
|
# Truncate long messages to keep the request small
|
|
user_snippet = user_message[:500] if user_message else ""
|
|
assistant_snippet = assistant_response[:500] if assistant_response else ""
|
|
|
|
messages = [
|
|
{"role": "system", "content": _TITLE_PROMPT},
|
|
{"role": "user", "content": f"User: {user_snippet}\n\nAssistant: {assistant_snippet}"},
|
|
]
|
|
|
|
try:
|
|
response = call_llm(
|
|
task="title_generation",
|
|
messages=messages,
|
|
max_tokens=500,
|
|
temperature=0.3,
|
|
timeout=timeout,
|
|
)
|
|
title = (response.choices[0].message.content or "").strip()
|
|
# Clean up: remove quotes, trailing punctuation, prefixes like "Title: "
|
|
title = title.strip('"\'')
|
|
if title.lower().startswith("title:"):
|
|
title = title[6:].strip()
|
|
# Enforce reasonable length
|
|
if len(title) > 80:
|
|
title = title[:77] + "..."
|
|
return title if title else None
|
|
except Exception as e:
|
|
# Log at WARNING so this shows up in agent.log without debug mode.
|
|
# Full detail at debug level for operators who need the stack.
|
|
logger.warning("Title generation failed: %s", e)
|
|
logger.debug("Title generation traceback", exc_info=True)
|
|
if failure_callback is not None:
|
|
try:
|
|
failure_callback("title generation", e)
|
|
except Exception:
|
|
logger.debug("Title generation failure_callback raised", exc_info=True)
|
|
return None
|
|
|
|
|
|
def auto_title_session(
|
|
session_db,
|
|
session_id: str,
|
|
user_message: str,
|
|
assistant_response: str,
|
|
failure_callback: Optional[FailureCallback] = None,
|
|
) -> None:
|
|
"""Generate and set a session title if one doesn't already exist.
|
|
|
|
Called in a background thread after the first exchange completes.
|
|
Silently skips if:
|
|
- session_db is None
|
|
- session already has a title (user-set or previously auto-generated)
|
|
- title generation fails
|
|
"""
|
|
if not session_db or not session_id:
|
|
return
|
|
|
|
# Check if title already exists (user may have set one via /title before first response)
|
|
try:
|
|
existing = session_db.get_session_title(session_id)
|
|
if existing:
|
|
return
|
|
except Exception:
|
|
return
|
|
|
|
title = generate_title(
|
|
user_message, assistant_response, failure_callback=failure_callback
|
|
)
|
|
if not title:
|
|
return
|
|
|
|
try:
|
|
session_db.set_session_title(session_id, title)
|
|
logger.debug("Auto-generated session title: %s", title)
|
|
except Exception as e:
|
|
logger.debug("Failed to set auto-generated title: %s", e)
|
|
|
|
|
|
def maybe_auto_title(
|
|
session_db,
|
|
session_id: str,
|
|
user_message: str,
|
|
assistant_response: str,
|
|
conversation_history: list,
|
|
failure_callback: Optional[FailureCallback] = None,
|
|
) -> None:
|
|
"""Fire-and-forget title generation after the first exchange.
|
|
|
|
Only generates a title when:
|
|
- This appears to be the first user→assistant exchange
|
|
- No title is already set
|
|
"""
|
|
if not session_db or not session_id or not user_message or not assistant_response:
|
|
return
|
|
|
|
# Count user messages in history to detect first exchange.
|
|
# conversation_history includes the exchange that just happened,
|
|
# so for a first exchange we expect exactly 1 user message
|
|
# (or 2 counting system). Be generous: generate on first 2 exchanges.
|
|
user_msg_count = sum(1 for m in (conversation_history or []) if m.get("role") == "user")
|
|
if user_msg_count > 2:
|
|
return
|
|
|
|
thread = threading.Thread(
|
|
target=auto_title_session,
|
|
args=(session_db, session_id, user_message, assistant_response),
|
|
kwargs={"failure_callback": failure_callback},
|
|
daemon=True,
|
|
name="auto-title",
|
|
)
|
|
thread.start()
|