mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-30 16:01:49 +08:00
d1ee4915f3
Fixes from Copilot's two passes on PR #17238: * Validate parsed URL once: reject missing host, invalid port, and unsupported scheme up front so malformed inputs (e.g. http://:9222 or http://localhost:abc) don't fall through to a generic 5031. * Tighten _is_default_local_cdp to require a discovery-style path so ws://127.0.0.1:9222/devtools/browser/<id> is not collapsed to bare http://127.0.0.1:9222 (which would lose the path and break the connect). * Move browser.manage into _LONG_HANDLERS so the up-to-10s launch-and-retry loop runs on the RPC pool instead of blocking the main dispatcher. * try_launch_chrome_debug uses Windows-appropriate detach kwargs (creationflags=DETACHED_PROCESS|CREATE_NEW_PROCESS_GROUP) instead of POSIX-only start_new_session=True. * manual_chrome_debug_command uses subprocess.list2cmdline on Windows so the printed instruction is cmd.exe-compatible. * Mirror host/port validation in cli.py /browser connect so the classic CLI never persists an invalid BROWSER_CDP_URL.
102 lines
4.9 KiB
Python
102 lines
4.9 KiB
Python
"""Tests for CLI browser CDP auto-launch helpers."""
|
|
|
|
import os
|
|
import subprocess
|
|
from unittest.mock import patch
|
|
|
|
from cli import HermesCLI
|
|
from hermes_cli.browser_connect import manual_chrome_debug_command
|
|
|
|
|
|
def _assert_chrome_debug_cmd(cmd, expected_chrome, expected_port):
|
|
"""Verify the auto-launch command has all required flags."""
|
|
assert cmd[0] == expected_chrome
|
|
assert f"--remote-debugging-port={expected_port}" in cmd
|
|
assert "--no-first-run" in cmd
|
|
assert "--no-default-browser-check" in cmd
|
|
user_data_args = [a for a in cmd if a.startswith("--user-data-dir=")]
|
|
assert len(user_data_args) == 1, "Expected exactly one --user-data-dir flag"
|
|
assert "chrome-debug" in user_data_args[0]
|
|
|
|
|
|
class TestChromeDebugLaunch:
|
|
def test_windows_launch_uses_browser_found_on_path(self):
|
|
captured = {}
|
|
|
|
def fake_popen(cmd, **kwargs):
|
|
captured["cmd"] = cmd
|
|
captured["kwargs"] = kwargs
|
|
return object()
|
|
|
|
with patch("hermes_cli.browser_connect.shutil.which", side_effect=lambda name: r"C:\Chrome\chrome.exe" if name == "chrome.exe" else None), \
|
|
patch("hermes_cli.browser_connect.os.path.isfile", side_effect=lambda path: path == r"C:\Chrome\chrome.exe"), \
|
|
patch("subprocess.Popen", side_effect=fake_popen):
|
|
assert HermesCLI._try_launch_chrome_debug(9333, "Windows") is True
|
|
|
|
_assert_chrome_debug_cmd(captured["cmd"], r"C:\Chrome\chrome.exe", 9333)
|
|
# Windows uses creationflags (POSIX-only start_new_session would raise).
|
|
assert "start_new_session" not in captured["kwargs"]
|
|
flags = captured["kwargs"].get("creationflags", 0)
|
|
expected = getattr(subprocess, "DETACHED_PROCESS", 0) | getattr(
|
|
subprocess, "CREATE_NEW_PROCESS_GROUP", 0
|
|
)
|
|
assert flags == expected
|
|
|
|
def test_windows_launch_falls_back_to_common_install_dirs(self, monkeypatch):
|
|
captured = {}
|
|
program_files = r"C:\Program Files"
|
|
# Use os.path.join so path separators match cross-platform
|
|
installed = os.path.join(program_files, "Google", "Chrome", "Application", "chrome.exe")
|
|
|
|
def fake_popen(cmd, **kwargs):
|
|
captured["cmd"] = cmd
|
|
captured["kwargs"] = kwargs
|
|
return object()
|
|
|
|
monkeypatch.setenv("ProgramFiles", program_files)
|
|
monkeypatch.delenv("ProgramFiles(x86)", raising=False)
|
|
monkeypatch.delenv("LOCALAPPDATA", raising=False)
|
|
|
|
with patch("hermes_cli.browser_connect.shutil.which", return_value=None), \
|
|
patch("hermes_cli.browser_connect.os.path.isfile", side_effect=lambda path: path == installed), \
|
|
patch("subprocess.Popen", side_effect=fake_popen):
|
|
assert HermesCLI._try_launch_chrome_debug(9222, "Windows") is True
|
|
|
|
_assert_chrome_debug_cmd(captured["cmd"], installed, 9222)
|
|
|
|
def test_manual_command_uses_detected_linux_browser(self):
|
|
with patch("hermes_cli.browser_connect.shutil.which", side_effect=lambda name: "/usr/bin/chromium" if name == "chromium" else None), \
|
|
patch("hermes_cli.browser_connect.os.path.isfile", side_effect=lambda path: path == "/usr/bin/chromium"):
|
|
command = manual_chrome_debug_command(9222, "Linux")
|
|
|
|
assert command is not None
|
|
assert command.startswith("/usr/bin/chromium --remote-debugging-port=9222")
|
|
|
|
def test_manual_command_uses_wsl_windows_chrome_when_available(self):
|
|
chrome = "/mnt/c/Program Files/Google/Chrome/Application/chrome.exe"
|
|
|
|
with patch("hermes_cli.browser_connect.shutil.which", return_value=None), \
|
|
patch("hermes_cli.browser_connect.os.path.isfile", side_effect=lambda path: path == chrome):
|
|
command = manual_chrome_debug_command(9222, "Linux")
|
|
|
|
assert command is not None
|
|
# Linux/WSL uses POSIX shell quoting (single quotes around paths with spaces).
|
|
assert command.startswith(f"'{chrome}' --remote-debugging-port=9222")
|
|
|
|
def test_manual_command_uses_windows_quoting_on_windows(self):
|
|
chrome = r"C:\Program Files\Google\Chrome\Application\chrome.exe"
|
|
|
|
with patch("hermes_cli.browser_connect.shutil.which", side_effect=lambda name: chrome if name == "chrome.exe" else None), \
|
|
patch("hermes_cli.browser_connect.os.path.isfile", side_effect=lambda path: path == chrome):
|
|
command = manual_chrome_debug_command(9222, "Windows")
|
|
|
|
assert command is not None
|
|
# Windows uses cmd.exe-compatible quoting via subprocess.list2cmdline.
|
|
assert command.startswith(f'"{chrome}" --remote-debugging-port=9222')
|
|
assert "'" not in command
|
|
|
|
def test_manual_command_returns_none_when_linux_browser_missing(self):
|
|
with patch("hermes_cli.browser_connect.shutil.which", return_value=None), \
|
|
patch("hermes_cli.browser_connect.os.path.isfile", return_value=False):
|
|
assert manual_chrome_debug_command(9222, "Linux") is None
|