mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-03 17:27:37 +08:00
a7780fe05f
The audit of v4.1 surfaced ~70 issues across the five scripts and three
reference docs — most user-visible (silent file overwrites, status-error
misclassified as success, X-API-Key leaked to S3 on /api/view redirect,
Cloud endpoints that 404 because they were renamed). v5.0.0 fixes those
and fills the gaps that previously forced users to write their own glue
(WebSocket monitoring, batch/sweep, img2img upload helper, dep auto-fix,
log fetch, health check, example workflows).
Critical fixes
- run_workflow.py: poll_status now checks status_str==error BEFORE
completed:true, so a failed run no longer reports success
- run_workflow.py: download_output streams to disk via safe_path_join,
preserves server subfolder structure (no silent overwrites), and
retries with exponential backoff
- run_workflow.py: refuses to overwrite a link with a literal in
inject_params (would silently break wiring)
- _common.py: _StripSensitiveOnRedirectSession (subclasses
requests.Session.rebuild_auth) drops X-API-Key/Cookie on cross-host
redirects — fixes a real key-leak path through Cloud's signed-URL
download flow. Tested
- Cloud routing (verified live): /history → /history_v2,
/models/<f> → /experiment/models/<f>, plus folder aliases for the
unet ↔ diffusion_models and clip ↔ text_encoders rename
- check_deps.py: distinguishes 200/empty vs 404 folder_not_found vs
403 free-tier; emits concrete fix_command per missing dep
- extract_schema.py: prompt vs negative_prompt determined by tracing
KSampler.{positive,negative} connections (incl. through Reroute /
Primitive nodes) instead of meta-title heuristic; symmetric
duplicate-name resolution; cycle-safe trace_to_node
- hardware_check.py: multi-GPU pick-best, Apple variant detection,
Rosetta detection, WSL2, ROCm --json, disk-space check, optional
PyTorch probe; powershell preferred over deprecated wmic
- comfyui_setup.sh: prefers pipx → uvx → pip --user (with PEP-668
fallback); idempotent — skips relaunch if server already up;
configurable port/workspace; persistent log; SIGINT trap
New scripts
- run_batch.py — count or sweep (cartesian product), parallel up to
cloud tier limit
- ws_monitor.py — real-time WebSocket viewer; saves preview frames
- auto_fix_deps.py — runs comfy node install / model download for
whatever check_deps reports missing (with --dry-run)
- health_check.py — single command that runs the verification checklist
(comfy-cli + server + checkpoints + optional smoke test that cancels
itself to avoid burning compute)
- fetch_logs.py — pull traceback / status messages for a prompt_id
Coverage expansion
- Param patterns now cover Flux (BasicScheduler, BasicGuider,
RandomNoise, ModelSamplingFlux), SD3, Wan/Hunyuan/LTX video,
IPAdapter, rgthree, easy-use, AnimateDiff
- Embedding refs in CLIPTextEncode strings extracted as model deps
- ckpt_name / vae_name / lora_name / unet_name now controllable so
workflows can be retargeted per run
Examples
- workflows/{sd15,sdxl,flux_dev}_txt2img.json
- workflows/sdxl_{img2img,inpaint}.json
- workflows/upscale_4x.json
- workflows/{animatediff_video,wan_video_t2v}.json + README
Tests
- 117 tests (105 unit + 8 cloud integration + 4 cross-host security)
- Cloud tests auto-skip without COMFY_CLOUD_API_KEY; verified end-to-end
against live cloud API
Backwards compatibility
- All existing CLI flags continue to work; new behavior is opt-in
(--ws, --input-image, --randomize-seed, --flat-output, etc.)
65 lines
1.4 KiB
Python
65 lines
1.4 KiB
Python
"""Pytest configuration for the comfyui skill test suite.
|
|
|
|
Adds `scripts/` to sys.path so tests can `from _common import ...`, and
|
|
provides a few common fixtures.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
SCRIPTS = ROOT / "scripts"
|
|
WORKFLOWS = ROOT / "workflows"
|
|
|
|
sys.path.insert(0, str(SCRIPTS))
|
|
|
|
|
|
@pytest.fixture
|
|
def sd15_workflow() -> dict:
|
|
return json.loads((WORKFLOWS / "sd15_txt2img.json").read_text())
|
|
|
|
|
|
@pytest.fixture
|
|
def flux_workflow() -> dict:
|
|
return json.loads((WORKFLOWS / "flux_dev_txt2img.json").read_text())
|
|
|
|
|
|
@pytest.fixture
|
|
def video_workflow() -> dict:
|
|
return json.loads((WORKFLOWS / "wan_video_t2v.json").read_text())
|
|
|
|
|
|
@pytest.fixture
|
|
def workflows_dir() -> Path:
|
|
return WORKFLOWS
|
|
|
|
|
|
@pytest.fixture
|
|
def scripts_dir() -> Path:
|
|
return SCRIPTS
|
|
|
|
|
|
@pytest.fixture
|
|
def cloud_key() -> str | None:
|
|
"""Cloud API key if set, otherwise None.
|
|
|
|
Tests that need cloud connectivity should skip when this is None.
|
|
"""
|
|
return os.environ.get("COMFY_CLOUD_API_KEY")
|
|
|
|
|
|
def pytest_collection_modifyitems(config, items):
|
|
"""Auto-skip cloud tests when no API key is set."""
|
|
if os.environ.get("COMFY_CLOUD_API_KEY"):
|
|
return
|
|
skip_cloud = pytest.mark.skip(reason="Set COMFY_CLOUD_API_KEY to run cloud tests")
|
|
for item in items:
|
|
if "cloud" in item.keywords:
|
|
item.add_marker(skip_cloud)
|