mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-05-02 16:57:36 +08:00
Salvage of PR #16100 onto current main (after emozilla's #17514 fix that unblocks plugin Pydantic body validation). History preserved on the standing `feat/kanban-standing` branch; this squashes the 22 iterative commits into one clean landing. What this lands: - SQLite kernel (hermes_cli/kanban_db.py) — durable task board with tasks, task_links, task_runs, task_comments, task_events, kanban_notify_subs tables. WAL mode, atomic claim via CAS, tenant-namespaced, skills JSON array per task, max-runtime timeouts, worker heartbeats, idempotency keys, circuit breaker on repeated spawn failures, crash detection via /proc/<pid>/status, run history preserved across attempts. - Dispatcher — runs inside the gateway by default (`kanban.dispatch_in_gateway: true`). Ticks every 60s, reclaims stale claims, promotes ready tasks, spawns `hermes -p <assignee> chat -q "work kanban task <id>"` with HERMES_KANBAN_TASK + HERMES_KANBAN_WORKSPACE env. Auto-loads `--skills kanban-worker` plus any per-task skills. Health telemetry warns on stuck ready queue. - Structured tool surface (tools/kanban_tools.py) — 7 tools (kanban_show, kanban_complete, kanban_block, kanban_heartbeat, kanban_comment, kanban_create, kanban_link). Gated on HERMES_KANBAN_TASK via check_fn so zero schema footprint in normal sessions. - System-prompt guidance (agent/prompt_builder.py KANBAN_GUIDANCE) injected only when kanban tools are active. - Dashboard plugin (plugins/kanban/dashboard/) — Linear-style board UI: triage/todo/ready/running/blocked/done columns, drag-drop, inline create, task drawer with markdown, comments, run history, dependency editor, bulk ops, lanes-by-profile grouping, WS-driven live refresh. Matches active dashboard theme via CSS variables. - CLI — `hermes kanban init|create|list|show|assign|link|unlink| claim|comment|complete|block|unblock|archive|tail|dispatch|context| init|gc|watch|stats|notify|log|heartbeat|runs|assignees` + `/kanban` slash in-session. - Worker + orchestrator skills (skills/devops/kanban-worker + kanban-orchestrator) — pattern library for good summary/metadata shapes, retry diagnostics, block-reason examples, fan-out patterns. - Per-task force-loaded skills — `--skill <name>` (repeatable), stored as JSON, threaded through to dispatcher argv as one `--skills X` pair per skill alongside the built-in kanban-worker. Dashboard + CLI + tool parity. - Deprecation of standalone `hermes kanban daemon` — stub exits 2 with migration guidance; `--force` escape hatch for headless hosts. - Docs (website/docs/user-guide/features/kanban.md + kanban-tutorial.md) with 11 dashboard screenshots walking through four user stories (Solo Dev, Fleet Farming, Role Pipeline, Circuit Breaker). - Tests (251 passing): kernel schema + migration + CAS atomicity, dispatcher logic, circuit breaker, crash detection, max-runtime timeouts, claim lifecycle, tenant isolation, idempotency keys, per- task skills round-trip + validation + dispatcher argv, tool surface (7 tools × round-trip + error paths), dashboard REST (CRUD + bulk + links + warnings), gateway-embedded dispatcher (config gate, env override, graceful shutdown), CLI deprecation stub, migration from legacy schemas. Gateway integration: - GatewayRunner._kanban_dispatcher_watcher — new asyncio background task, symmetric with _kanban_notifier_watcher. Runs dispatch_once via asyncio.to_thread so SQLite WAL never blocks the loop. Sleeps in 1s slices for snappy shutdown. Respects HERMES_KANBAN_DISPATCH_IN_GATEWAY=0 env override for debugging. - Config: new `kanban` section in DEFAULT_CONFIG with `dispatch_in_gateway: true` (default) + `dispatch_interval_seconds: 60`. Additive — no \_config_version bump needed. Forward-compat: - workflow_template_id / current_step_key columns on tasks (v1 writes NULL; v2 will use them for routing). - task_runs holds claim machinery (claim_lock, claim_expires, worker_pid, last_heartbeat_at) so multi-attempt history is first- class from day one. Closes #16102. Co-authored-by: emozilla <emozilla@nousresearch.com>
211 lines
6.8 KiB
Python
211 lines
6.8 KiB
Python
"""Tests for the kanban CLI surface (hermes_cli.kanban)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import kanban as kc
|
|
from hermes_cli import kanban_db as kb
|
|
|
|
|
|
@pytest.fixture
|
|
def kanban_home(tmp_path, monkeypatch):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
kb.init_db()
|
|
return home
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Workspace flag parsing
|
|
# ---------------------------------------------------------------------------
|
|
|
|
@pytest.mark.parametrize(
|
|
"value,expected",
|
|
[
|
|
("scratch", ("scratch", None)),
|
|
("worktree", ("worktree", None)),
|
|
("dir:/tmp/work", ("dir", "/tmp/work")),
|
|
],
|
|
)
|
|
def test_parse_workspace_flag_valid(value, expected):
|
|
assert kc._parse_workspace_flag(value) == expected
|
|
|
|
|
|
def test_parse_workspace_flag_expands_user():
|
|
kind, path = kc._parse_workspace_flag("dir:~/vault")
|
|
assert kind == "dir"
|
|
assert path.endswith("/vault")
|
|
assert not path.startswith("~")
|
|
|
|
|
|
@pytest.mark.parametrize("bad", ["cloud", "dir:", "", "worktree:/x"])
|
|
def test_parse_workspace_flag_rejects(bad):
|
|
if not bad:
|
|
# Empty -> defaults; not an error.
|
|
assert kc._parse_workspace_flag(bad) == ("scratch", None)
|
|
return
|
|
with pytest.raises(argparse.ArgumentTypeError):
|
|
kc._parse_workspace_flag(bad)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# run_slash smoke tests (end-to-end via the same entry both CLI and gateway use)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_run_slash_no_args_shows_usage(kanban_home):
|
|
out = kc.run_slash("")
|
|
assert "kanban" in out.lower()
|
|
assert "create" in out.lower() or "subcommand" in out.lower() or "action" in out.lower()
|
|
|
|
|
|
def test_run_slash_create_and_list(kanban_home):
|
|
out = kc.run_slash("create 'ship feature' --assignee alice")
|
|
assert "Created" in out
|
|
out = kc.run_slash("list")
|
|
assert "ship feature" in out
|
|
assert "alice" in out
|
|
|
|
|
|
def test_run_slash_create_with_parent_and_cascade(kanban_home):
|
|
# Parent then child via --parent
|
|
out1 = kc.run_slash("create 'parent' --assignee alice")
|
|
# Extract the "t_xxxx" id from "Created t_xxxx (ready, ...)"
|
|
import re
|
|
m = re.search(r"(t_[a-f0-9]+)", out1)
|
|
assert m
|
|
p = m.group(1)
|
|
out2 = kc.run_slash(f"create 'child' --assignee bob --parent {p}")
|
|
assert "todo" in out2 # child starts as todo
|
|
|
|
# Complete parent; list should promote child to ready
|
|
kc.run_slash(f"complete {p}")
|
|
# Explicit filter: child should now be ready (was todo before complete).
|
|
ready_list = kc.run_slash("list --status ready")
|
|
assert "child" in ready_list
|
|
|
|
|
|
def test_run_slash_show_includes_comments(kanban_home):
|
|
out = kc.run_slash("create 'x'")
|
|
import re
|
|
tid = re.search(r"(t_[a-f0-9]+)", out).group(1)
|
|
kc.run_slash(f"comment {tid} 'source is paywalled'")
|
|
show = kc.run_slash(f"show {tid}")
|
|
assert "source is paywalled" in show
|
|
|
|
|
|
def test_run_slash_block_unblock_cycle(kanban_home):
|
|
out = kc.run_slash("create 'x' --assignee alice")
|
|
import re
|
|
tid = re.search(r"(t_[a-f0-9]+)", out).group(1)
|
|
# Claim first so block() finds it running
|
|
kc.run_slash(f"claim {tid}")
|
|
assert "Blocked" in kc.run_slash(f"block {tid} 'need decision'")
|
|
assert "Unblocked" in kc.run_slash(f"unblock {tid}")
|
|
|
|
|
|
def test_run_slash_json_output(kanban_home):
|
|
out = kc.run_slash("create 'jsontask' --assignee alice --json")
|
|
payload = json.loads(out)
|
|
assert payload["title"] == "jsontask"
|
|
assert payload["assignee"] == "alice"
|
|
assert payload["status"] == "ready"
|
|
|
|
|
|
def test_run_slash_dispatch_dry_run_counts(kanban_home):
|
|
kc.run_slash("create 'a' --assignee alice")
|
|
kc.run_slash("create 'b' --assignee bob")
|
|
out = kc.run_slash("dispatch --dry-run")
|
|
assert "Spawned:" in out
|
|
|
|
|
|
def test_run_slash_context_output_format(kanban_home):
|
|
out = kc.run_slash("create 'tech spec' --assignee alice --body 'write an RFC'")
|
|
import re
|
|
tid = re.search(r"(t_[a-f0-9]+)", out).group(1)
|
|
kc.run_slash(f"comment {tid} 'remember to include performance section'")
|
|
ctx = kc.run_slash(f"context {tid}")
|
|
assert "tech spec" in ctx
|
|
assert "write an RFC" in ctx
|
|
assert "performance section" in ctx
|
|
|
|
|
|
def test_run_slash_tenant_filter(kanban_home):
|
|
kc.run_slash("create 'biz-a task' --tenant biz-a --assignee alice")
|
|
kc.run_slash("create 'biz-b task' --tenant biz-b --assignee alice")
|
|
a = kc.run_slash("list --tenant biz-a")
|
|
b = kc.run_slash("list --tenant biz-b")
|
|
assert "biz-a task" in a and "biz-b task" not in a
|
|
assert "biz-b task" in b and "biz-a task" not in b
|
|
|
|
|
|
def test_run_slash_usage_error_returns_message(kanban_home):
|
|
# Missing required argument for create
|
|
out = kc.run_slash("create")
|
|
assert "usage" in out.lower() or "error" in out.lower()
|
|
|
|
|
|
def test_run_slash_assign_reassigns(kanban_home):
|
|
out = kc.run_slash("create 'x' --assignee alice")
|
|
import re
|
|
tid = re.search(r"(t_[a-f0-9]+)", out).group(1)
|
|
assert "Assigned" in kc.run_slash(f"assign {tid} bob")
|
|
show = kc.run_slash(f"show {tid}")
|
|
assert "bob" in show
|
|
|
|
|
|
def test_run_slash_link_unlink(kanban_home):
|
|
a = kc.run_slash("create 'a'")
|
|
b = kc.run_slash("create 'b'")
|
|
import re
|
|
ta = re.search(r"(t_[a-f0-9]+)", a).group(1)
|
|
tb = re.search(r"(t_[a-f0-9]+)", b).group(1)
|
|
assert "Linked" in kc.run_slash(f"link {ta} {tb}")
|
|
# After link, b is todo
|
|
show = kc.run_slash(f"show {tb}")
|
|
assert "todo" in show
|
|
assert "Unlinked" in kc.run_slash(f"unlink {ta} {tb}")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Integration with the COMMAND_REGISTRY
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def test_kanban_is_resolvable():
|
|
from hermes_cli.commands import resolve_command
|
|
|
|
cmd = resolve_command("kanban")
|
|
assert cmd is not None
|
|
assert cmd.name == "kanban"
|
|
|
|
|
|
def test_kanban_bypasses_active_session_guard():
|
|
from hermes_cli.commands import should_bypass_active_session
|
|
|
|
assert should_bypass_active_session("kanban")
|
|
|
|
|
|
def test_kanban_in_autocomplete_table():
|
|
from hermes_cli.commands import COMMANDS, SUBCOMMANDS
|
|
|
|
assert "/kanban" in COMMANDS
|
|
subs = SUBCOMMANDS.get("/kanban") or []
|
|
assert "create" in subs
|
|
assert "dispatch" in subs
|
|
|
|
|
|
def test_kanban_not_gateway_only():
|
|
# kanban is available in BOTH CLI and gateway surfaces.
|
|
from hermes_cli.commands import COMMAND_REGISTRY
|
|
|
|
cmd = next(c for c in COMMAND_REGISTRY if c.name == "kanban")
|
|
assert not cmd.cli_only
|
|
assert not cmd.gateway_only
|