mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-04-29 07:21:37 +08:00
896e7b03e8
Shallow-copy client_kwargs at the top of _create_openai_client() to prevent in-place mutation from leaking back into self._client_kwargs. Defensive fix that locks the contract for future httpx/transport work. Cherry-picked from #10978 by @taeuk178.
36 lines
1.4 KiB
Python
36 lines
1.4 KiB
Python
"""Guardrail: _create_openai_client must not mutate its input kwargs.
|
|
|
|
#10933 injected an httpx.Client directly into the caller's ``client_kwargs``.
|
|
When the dict was ``self._client_kwargs``, the shared transport was torn down
|
|
after the first request_complete close and subsequent request-scoped clients
|
|
wrapped a closed transport, raising ``APIConnectionError('Connection error.')``
|
|
with cause ``RuntimeError: Cannot send a request, as the client has been closed``
|
|
on every retry. That PR has since been reverted, but the underlying issue
|
|
(#10324, connections hanging in CLOSE-WAIT) is still open, so another transport
|
|
tweak inside this function is likely. This test pins the contract that the
|
|
function must treat its input dict as read-only.
|
|
"""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
@patch("run_agent.OpenAI")
|
|
def test_create_openai_client_does_not_mutate_input_kwargs(mock_openai):
|
|
mock_openai.return_value = MagicMock()
|
|
agent = AIAgent(
|
|
model="test/model",
|
|
quiet_mode=True,
|
|
skip_context_files=True,
|
|
skip_memory=True,
|
|
)
|
|
|
|
kwargs = {"api_key": "test-key", "base_url": "https://api.example.com/v1"}
|
|
snapshot = dict(kwargs)
|
|
|
|
agent._create_openai_client(kwargs, reason="test", shared=False)
|
|
|
|
assert kwargs == snapshot, (
|
|
f"_create_openai_client mutated input kwargs; expected {snapshot}, got {kwargs}"
|
|
)
|